c#: Remove Copy of data during import call for base types #1122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for cannoncal types. This avoid the extra copy of data in this scenario Signed-off-by: James Sturtevant <[email protected]>
jsturtevant
commented
Jan 10, 2025
| @@ -1063,7 +1064,7 @@ impl Bindgen for FunctionBindgen<'_, '_> { | |||
|
|
|||
| match direction { | |||
| Direction::Import => { | |||
| let import_name = self.interface_gen.type_name_with_qualifier(&Type::Id(id), true); | |||
| let import_name = self.interface_gen.type_name_with_qualifier(&Type::Id(id), true); | |||
There was a problem hiding this comment.
Some how these two lines had tabs, while rest of the file was spaces
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When calling an import we don't need to copy data to a new structure for canonical types. This avoid the extra copy of data in this scenario.
This isin prep for some more changes with #1080